-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Migrate mono-repo dependency versions to use yarn workspace syntax #23572
Build: Migrate mono-repo dependency versions to use yarn workspace syntax #23572
Conversation
e774bc0
to
a481660
Compare
Let's discuss today @valentinpalkovic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn npm publish would call internally yarn pack. So this would be a win. Unfortuately, it doesn't support the same CLI arguments then npm publish. Therefore first yarn pack is called to create a package.tgz per package, and with npm publish package.tgz this package is taken to publish to npm. Therefore, npm isn't responsible anymore to build the package. It only takes the tarball archive and publishes it.
I don't really follow this. If yarn npm publish
already runs yarn pack
, why do you want to run npm publish
separately? You say that "it doesn't support the same CLI arguments then npm publish", but as far as I can see you don't supply any other arguments other than the .tgz
file, which I would think wouldn't be needed at all if you just used yarn npm publish
?
What I'm saying is, isn't yarn pack && npm publish ./package.tgz --tolerate-republish --tag ${tag}
the exact same thing as yarn npm publish --tolerate-republish --tag ${tag}
?
You're right! For the actual release, we might be able to switch to |
Oh I see what you mean. Yeah all of this makes sense to me. |
…ion-to-use-workspace-syntax
…ion-to-use-workspace-syntax
…ion-to-use-workspace-syntax
54934ae
to
33efd3d
Compare
Closes N/A
What I did
How to test
Checklist
MIGRATION.MD
Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]
This pull request has been released as version
7.2.0-canary-23572-1690275421-726e1551.0
. Install it by pinning all your Storybook dependencies to that version.More information
7.2.0-canary-23572-1690275421-726e1551.0
valentin/migrate-version-to-use-workspace-syntax
726e1551
1690275421
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=23572